fix: relax validation rules for major in beacons
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please use the proposed template shown when opening a PullRequest? Thank you! |
|
@alexandercerutti |
AbdelrahmanHafez
changed the title
major\ in beaconsmajor in beacons
alexandercerutti
approved these changes
Aug 13, 2023
alexandercerutti
merged commit ab1aaeb
into
alexandercerutti:master
1 of 7 checks passed
|
Released in v3.1.11 🎉 Thank you very much @AbdelrahmanHafez! If you could leave a ⭐️ on the project, that would be awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #157
This PR relaxes
majorvalidation in beacons.Check relevant checkboxes
npm test) and they passedRelevant information
Look at #157 for more information about the issue.
Example of a working pass: https://file.io/f1XIkfUuzC96