Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/update readme #11

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Docs/update readme #11

merged 5 commits into from
Apr 23, 2024

Conversation

saattrupdan
Copy link
Collaborator

Update the readme with instructions, and a general overview of the setup.

@saattrupdan saattrupdan requested a review from AJDERS April 23, 2024 12:10
@saattrupdan saattrupdan self-assigned this Apr 23, 2024
AJDERS
AJDERS suggested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@AJDERS AJDERS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the supported types used in the config to the overview of the concrete classes in the readme.

@saattrupdan saattrupdan requested a review from AJDERS April 23, 2024 12:17
AJDERS
AJDERS approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@AJDERS AJDERS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saattrupdan saattrupdan merged commit d34a903 into main Apr 23, 2024
1 of 2 checks passed
@saattrupdan saattrupdan deleted the docs/update-readme branch April 23, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJDERS AJDERS AJDERS approved these changes

Assignees

@saattrupdan saattrupdan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saattrupdan @AJDERS