Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/embedder #9

Merged
merged 20 commits into from
Apr 23, 2024
Merged

Feat/embedder #9

merged 20 commits into from
Apr 23, 2024

Conversation

AJDERS
Copy link
Contributor

@AJDERS AJDERS commented Apr 23, 2024

This PR adds the Embedder and the `EmbeddingStore´ classes.

This PR closes #3 and #2 .

@AJDERS AJDERS requested a review from saattrupdan April 23, 2024 08:51
src/ragger/embedder.py Outdated Show resolved Hide resolved
src/ragger/embedder.py Outdated Show resolved Hide resolved
src/ragger/embedder.py Outdated Show resolved Hide resolved
src/ragger/embedding_store.py Outdated Show resolved Hide resolved
src/ragger/embedding_store.py Outdated Show resolved Hide resolved
src/ragger/embedding_store.py Show resolved Hide resolved
src/ragger/embedding_store.py Outdated Show resolved Hide resolved
src/ragger/embedding_store.py Outdated Show resolved Hide resolved
tests/test_embedder.py Outdated Show resolved Hide resolved
@AJDERS AJDERS requested a review from saattrupdan April 23, 2024 09:38
Copy link
Collaborator

@saattrupdan saattrupdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/ragger/embedder.py Outdated Show resolved Hide resolved
@saattrupdan saattrupdan merged commit 49e4d0a into main Apr 23, 2024
2 checks passed
@saattrupdan saattrupdan deleted the feat/embedder branch April 23, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EmbeddingStore
2 participants