Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hard-coded 512 with BLOCK_SIZE #394

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Replace hard-coded 512 with BLOCK_SIZE #394

merged 1 commit into from
Dec 9, 2024

Conversation

xzfc
Copy link
Collaborator

@xzfc xzfc commented Dec 9, 2024

Extracted from #298. Unlike the original PR, I made the new constant u64 instead of usize to reduce amount of type casts.

@xzfc xzfc requested a review from cgwalters December 9, 2024 22:20
cgwalters
cgwalters approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cgwalters cgwalters merged commit b6c5024 into alexcrichton:main Dec 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xzfc @cgwalters