Invocable approval helper #1252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Henk. This looks like a great improvement. What do you think of the idea of keeping the same name 'ResolveApprovalRequest'? We generally prefer to upgrade actions in place. It keeps things clearer. |
|
I realize now that Tamar also provide a pull request with fixes, at #1281. |
|
Hi, checking back again. Let me know if you'd like to discuss this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use the flow action as shown on this article:
https://unofficialsf.com/use-flow-to-approve-reject-and-cancel-approval-processes/
As I now see in the comments the suggested code does not work, I investigated further and saw room for improvement.
I created 2 classes to be able to use the invocable approval actions
I removed the original flow example as it wasn't even calling the invocable action that was created in the article.
Other than that, it still works as described in the article