Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object And Field picklist updates #1549

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

StreckerCM
Copy link
Contributor

Updated field property to support multiple fields when allowFieldMultiselect is true

Implemented masterLabel property on the HTML template. This property was captured but was not implemented on the template.

Removed the property testproperty because it was not used anywhere and looked to be remnant of debugging.

Updated the field property to allow multiple selected fields to be passed into the component when allowFieldMultiselect is true.

There is a check to see if the fields in the property field is available on the selected object. This check existed in the loop that got all the objects field. It did not use any of the variables from the loop. If the pass field did not exist on the object the property would be cleared, and the check would only occur on the first loop. However, if the field is part of the selected object this check would occur on each loop. I moved this check outside of the loop prior to the start of the loop.

…imneted master label on template

Removed testproperty
Removed fieldList check from for loop
Updated fieldList to support multiple inputs when allowFieldMultiselect is true
Implemented master label section
Copy link
Collaborator

@ericrsmith35 ericrsmith35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does leaving the API version at 46.0 mean that newer objects are unavailable to the component?

@jdayment
Copy link
Collaborator

jdayment commented Jun 20, 2024 via email

@StreckerCM
Copy link
Contributor Author

Is it safe for me to update the API version to 61 because the Summer '24 deployment is ongoing?

I don't think that should impact it the fields and objects should be returned from the controller the API version of the controller should be what the results are but I think we will want to update component APIs going forward though based on the latest release notes I think API version will start having and impact on lightning component updates.

On Thu, Jun 20, 2024, 1:32 PM Eric Smith @.> wrote: @.* commented on this pull request. Does leaving the API version at 46.0 mean that newer objects are unavailable to the component? — Reply to this email directly, view it on GitHub <#1549 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS7YTZIAYSOJJEY75KDY3ZIM37HAVCNFSM6AAAAABJUUOSQ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZRGMYDANBQGY . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

@StreckerCM
Copy link
Contributor Author

Also I see another component ObjectAndFieldPickerFSC that is outside of the FlowScreenComponentsBasePack does that need to be in sync with the base pack version?

Is it safe for me to update the API version to 61 because the Summer '24 deployment is ongoing?

I don't think that should impact it the fields and objects should be returned from the controller the API version of the controller should be what the results are but I think we will want to update component APIs going forward though based on the latest release notes I think API version will start having and impact on lightning component updates.

On Thu, Jun 20, 2024, 1:32 PM Eric Smith @.> wrote: _@**._* commented on this pull request. Does leaving the API version at 46.0 mean that newer objects are unavailable to the component? — Reply to this email directly, view it on GitHub <#1549 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS7YTZIAYSOJJEY75KDY3ZIM37HAVCNFSM6AAAAABJUUOSQ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZRGMYDANBQGY . You are receiving this because you are subscribed to this thread.Message ID: _@_.* com>

Change API Version from 46 to 60
@StreckerCM
Copy link
Contributor Author

@jdayment and @ericrsmith35 I updated the API version to 60.0 on this component

@alexed1
Copy link
Owner

alexed1 commented Jul 5, 2024

StreckerCM, thanks for these enhancements! We don't get such careful scrutiny of the screen code very often, and I relly value it.

I'm pretty sure that the component with FSC on the end is obsolete. All the modern components that go into the screen components base pack start with 'fsc_' so you can ignore the ObjectAndFieldPickerFSC.

@jdayment can you code review this?

@alexed1 alexed1 requested a review from jdayment July 5, 2024 01:43
Copy link
Collaborator

@jdayment jdayment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the descriptive comments everything looks good on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants