Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow combobox global variable fix #1581

Merged

Conversation

adamerstelle
Copy link
Contributor

@adamerstelle adamerstelle commented Sep 12, 2024

Includes 3 fixes:

  • Fix typo refrence to reference
  • Includes the global variable root in the name and label
  • prevents the click event of choosing a variable from being handled 3 times

I've also commented out a couple of console.log lines that maybe shouldn't have made it to production code.

Original details and video showing issues in the Ohana Slack channel: https://salesforceohana.slack.com/archives/C6M0MJ2R0/p1725906250479449

@alexed1
Copy link
Owner

alexed1 commented Sep 21, 2024

Thanks for these fixes, Adam! I'd love to see the details and video that you mention above, but wasn't able to figure out how to join that slack channel. Any suggestions?

@adamerstelle
Copy link
Contributor Author

The link is to the Ohana Slack group, the #code-development channel.

Details included here too:

I'm having a bunch of challenges getting the UnofficialSF fsc_flowCombobox working in my own Project. If I use any of the Global Variables I get a bunch of LWC JS errors, but I can use other variables and record variables just fine. I've been trying to debug this for a few days now, and while I think I found one issue with the fsc_flowCombobox, I still can't get it to work 100% right.

With the exception of the Global Variables, the rest works fine. I've scoured the USF site and all of what Google can find looking for help with no luck (including looking at the USF code itself). Guess I just gotta work through it more

As I dug into the issue, I commented:

The first issue I had I think I solved by modifying the fsc_flowCombobox's doOpenGlobalVariable method to set the value of the top-level global variable name (such as $User etc). Without this, the valuechanged newValue only had the attribute name (such as Username) not the whole path $User.Username (I mimicked the pattern from the other doOpen methods)

Steps to reproduce:

  1. Creating new scratch org, no namespace
  2. Installing FlowActionsBasePack by packageId
  3. SFDX Pushing FlowScreenComponentsBasePack code directly into scratch org
  4. SFDX Pushing GetRecordsIn ccode directly into scratch org
  5. Creating a new Flow, using the "Get Records IN by Eric Smith" action
  6. Setting a few values, trying to use the $User.Username Global Variable

Recording of error: https://app.screencast.com/oRyKCdWTnWm27

@alexed1 alexed1 merged commit f140064 into alexed1:master Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants