Fix issues with PR for cert-manager

Corrects the order of the arguments for the apply command which
stopped the CRD from working. Also adds app to the list of
available.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

Gopkg.toml

@@ -8,5 +8,5 @@
 
 
 [[constraint]]
-  version = "0.1.0"
+  version = "0.1.1"
   name = "github.com/alexellis/go-execute"

README.md

@@ -112,6 +112,9 @@ k3sup app install metrics-server    # PC only
 # Get a public IP / Service LoadBalancer via DigitalOcean
 # or Packet.com
 k3sup app install inlets-operator   # PC only
+
+# cert-manager - obtain free TLS certificates from LetsEncrypt
+k3sup app install cert-manager
 ```
 
 Find out more:

pkg/cmd/certmanager_app.go

@@ -14,8 +14,8 @@ func makeInstallCertManager() *cobra.Command {
 	var certManager = &cobra.Command{
 		Use:          "cert-manager",
 		Short:        "Install cert-manager",
-		Long:         "Install Cert-Manager",
-		Example:      "k3sup install cert-manager --namespace cert-manager",
+		Long:         "Install cert-manager for obtaining TLS certificates from LetsEncrypt",
+		Example:      "k3sup install cert-manager",
 		SilenceUsage: true,
 	}
 
@@ -86,12 +86,17 @@ func makeInstallCertManager() *cobra.Command {
 			return err
 		}
 
-		err = kubectl("apply", "-f", "--validate", "false", "https://raw.githubusercontent.com/jetstack/cert-manager/release-0.11/deploy/manifests/00-crds.yaml")
+		log.Printf("Applying CRD\n")
+
+		res, err := kubectlTask("apply", "--validate=false", "-f", "https://raw.githubusercontent.com/jetstack/cert-manager/release-0.11/deploy/manifests/00-crds.yaml")
 		if err != nil {
 			return err
 		}
+		if len(res.Stderr) > 0 {
+			return fmt.Errorf("Error applying CRD: %s", res.Stderr)
+		}
 
-		err = kubectl("apply", "-n", namespace, "-R", "-f", outputPath)
+		err = kubectl("apply", "-R", "-f", outputPath)
 		if err != nil {
 			return err
 		}

pkg/cmd/kubernetes_exec.go

@@ -43,6 +43,12 @@ func getArchitecture() string {
 
 func templateChart(basePath, chart, namespace, outputPath, values string, overrides map[string]string) error {
 
+	rmErr := os.RemoveAll(outputPath)
+
+	if rmErr != nil {
+		log.Printf("Error cleaning up: %s, %s\n", outputPath, rmErr.Error())
+	}
+
 	mkErr := os.MkdirAll(outputPath, 0700)
 	if mkErr != nil {
 		return mkErr