Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Fix build error with conversion from Nan::Maybe<double> to v8::Maybe<double> #5

Closed
wants to merge 1 commit into from
Closed

Fix build error with conversion from Nan::Maybe<double> to v8::Maybe<double> #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Porcupine
Open in desktop
Submodule Porcupine updated from 484714 to 937f61
2 changes: 1 addition & 1 deletion src/porcupine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ static bool parseKeyword(v8::Local<v8::Value> keyword, std::string &keyword_file
}

v8::MaybeLocal<v8::String> filePathVal = Nan::To<v8::String>(Nan::Get(keywordObject, filePathKeyStr).ToLocalChecked());
v8::Maybe<double> sensitivityVal = Nan::To<double>(Nan::Get(keywordObject, sensitivityKeyStr).ToLocalChecked());
Nan::Maybe<double> sensitivityVal = Nan::To<double>(Nan::Get(keywordObject, sensitivityKeyStr).ToLocalChecked());
if (filePathVal.IsEmpty() || sensitivityVal.IsNothing())
{
return false;
Expand Down