Skip to content

Commit

Permalink
Disable ncurses for oksh
Browse files Browse the repository at this point in the history
When moving all builds to a single Docker stage, the shells started
to build all in the same machine, causing oksh to be linked against
ncurses.

Since the build stage is different from the final image, ncurses
was missing and causing oksh binaries to fail invokation.

This change disables linking against ncurses during build, fixing
the issue.

Our goal is not to provide interactive shells for personal use,
so lacking ncurses still results in a perfectly good oksh.
  • Loading branch information
alganet committed Jul 6, 2024
1 parent 4000d77 commit fd40efb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ FROM debian:buster-slim AS builder
ARG TARGETS

# Build
RUN sh "/shvr/shvr.sh" build $TARGETS
RUN bash "/shvr/shvr.sh" build $TARGETS

FROM debian:buster-slim

Expand Down
1 change: 1 addition & 0 deletions variants/oksh.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ shvr_build_oksh ()
cd "${build_srcdir}"

./configure \
--disable-curses \
--prefix="${SHVR_DIR_OUT}/oksh_$version"

make -j "$(nproc)"
Expand Down

0 comments on commit fd40efb

Please sign in to comment.