Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(indexing): JsonElement as param of Partial.Update #404

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix(indexing): JsonElement as param of Partial.Update #404

merged 1 commit into from
Aug 21, 2023

Conversation

aallam
Copy link
Member

@aallam aallam commented Aug 21, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #402
Need Doc update no

Describe your change

Allow JsonElement as parameter of Partial.Update, including JsonNull (or JsonPrimitive(null)).

@aallam aallam requested review from a team, damcou and millotp and removed request for a team August 21, 2023 08:52
@aallam aallam merged commit 4c98e84 into master Aug 21, 2023
1 of 2 checks passed
@aallam aallam deleted the fix/partial-update-nullable branch August 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou was automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set attribute to null in partial update
2 participants
@aallam @millotp