Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGE-1030: Fix client creation #1618

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Sep 18, 2024

This change includes:

  • Removal of client creation in the constructor to avoid such issues in the future
  • Prevented unhandled crash on category merchandising when no credentials are configured at Default level
  • Feedback to the user is now handled by the AlgoliaCredentialsManager class

Copy link
Contributor

@cammonro cammonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good we caught this scenario. Definitely don't want exceptions preventing injection of the helper class. However, I am concerned about the approach of not throwing exceptions at all.

Helper/AlgoliaHelper.php Show resolved Hide resolved
Helper/AlgoliaHelper.php Outdated Show resolved Hide resolved
Helper/AlgoliaHelper.php Outdated Show resolved Hide resolved
Helper/AlgoliaHelper.php Outdated Show resolved Hide resolved
Copy link
Contributor

@cammonro cammonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@damcou damcou merged commit dc4be0a into epic/MAGE-978/multi-apps Sep 20, 2024
3 checks passed
@damcou damcou deleted the bugfix/MAGE-1030-fix-client-creation branch September 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants