feat: upgrade to newest API client version #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevinCodes
changed the title
millotp
reviewed
Oct 14, 2024
| parameters: | ||
| version: ['3.0', '3.1'] | ||
| rails-version: ['7.0'] | ||
| sequel-version: ['5.0'] |
There was a problem hiding this comment.
first time I'm seeing it written like it's pronounced
There was a problem hiding this comment.
Haha, yes this is for a gem named sequel 😄
Oh good catch, this is not possible right now! It used to be possible, but we don't use this user agent in the new client, I'll add that! |
millotp
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
This upgrades the RoR client to support v3 of the Algolia API client. This introduces some breaking changes, mostly in responses when doing a search and some methods that are deprecated or change return types. I'll try to document these breaking changes as best as I can.