feat(javascript): add cache TTL and fix support message #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
reviewed
Jan 3, 2024
| Object.entries(filteredNamespaceWithoutOldFormattedCacheItems).filter( | ||
| ([, cacheItem]) => { | ||
| const currentTimestamp = new Date().getTime(); | ||
| const isExpired = cacheItem.timestamp + timeToLive < currentTimestamp; |
There was a problem hiding this comment.
what happens when timeToLive is null ? shouldn't you just early return instead of doing the addition here ?
There was a problem hiding this comment.
those are already filtered
I did not touched the actual implementation just in case we broke something non tested
There was a problem hiding this comment.
oh yeah it's just above I missed it
millotp
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1741
closes #2470
closes #1489
Changes included:
this PR port changes from the v4 version: