Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): support http #2639

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix(go): support http #2639

merged 2 commits into from
Jan 30, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 30, 2024

🧭 What and Why

Go path encoding is messed up, and it doesn't support http

Verified

This commit was signed with the committer’s verified signature.
millotp Pierre Millot
@millotp millotp self-assigned this Jan 30, 2024
Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit a529a10
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65b8da223a0fea0008764c2a
😎 Deploy Preview https://deploy-preview-2639--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 30, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Verified

This commit was signed with the committer’s verified signature.
millotp Pierre Millot
@millotp millotp marked this pull request as ready for review January 30, 2024 11:14
@millotp millotp requested a review from a team as a code owner January 30, 2024 11:14
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do this to support localhost testing, right?
Because swift doesn't support http either, right now 😢 I'll have to do like you

@millotp
Copy link
Collaborator Author

millotp commented Jan 30, 2024

Yes this is a fix for #2633

@millotp millotp merged commit 366c994 into main Jan 30, 2024
16 checks passed
@millotp millotp deleted the fix/go-path branch January 30, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants