fix(scripts): do not run notifications on forks #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
|
Fluf22
approved these changes
Jul 1, 2024
| @@ -419,6 +440,17 @@ jobs: | |||
| GITHUB_TOKEN: ${{ secrets.ALGOLIA_BOT_TOKEN }} | |||
| PR_NUMBER: ${{ github.event.number }} | |||
|
|
|||
| - name: update generation commend | |||
There was a problem hiding this comment.
Suggested change
| - name: update generation commend | |
| - name: update generation comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2543
Changes included:
gave an unsuccessful try on #3293 at running the notifications steps on forks, tldr it's not possible without leaking secrets, so for now we will just skip the message
also gave a shot at https://github.com/marocchino/sticky-pull-request-comment which removes a lot of custom logic