fix(clients): remove all client side validation expect null check #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
approved these changes
Oct 9, 2024
algolia-bot
added a commit
that referenced
this pull request
Oct 9, 2024
) (generated) [skip ci] Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Oct 9, 2024
…nerated) algolia/api-clients-automation#3936 Co-authored-by: algolia-bot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Oct 9, 2024
…nerated) algolia/api-clients-automation#3936 Co-authored-by: algolia-bot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Oct 9, 2024
…nerated) algolia/api-clients-automation#3936 Co-authored-by: algolia-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: DI-3031
closes algolia/algoliasearch-client-ruby#506
The client should delegate all validation to the API, or default value setting.
This is because if the API changes the bounds for example, we should not prevent the client from calling the API.
I left nil validation because it can cause other issues, and we have it in the legacy clients.