Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): correct type for banners [skip-bc] #3939

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 9, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-3036

closes #3934

Fix the type to match the example in #3934

@millotp millotp self-assigned this Oct 9, 2024
@millotp millotp requested a review from a team as a code owner October 9, 2024 22:34
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 9, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 9c080bed6235f974358e461a2f1691563449ca58
🍃 Generated commit 136c54dbeb8143d4899c6da3fe0b64e71786a8a9
🌲 Generated branch generated/fix/banner-link
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1703
go 1594
php 1452
csharp 1395
java 1141
python 1027
ruby 922
swift 770

@millotp millotp changed the title fix(specs): correct type for banners fix(specs): correct type for banners [skip-bc] Oct 9, 2024
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it.

@millotp millotp merged commit 45d433d into main Oct 10, 2024
28 checks passed
@millotp millotp deleted the fix/banner-link branch October 10, 2024 10:29
algolia-bot added a commit that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 10, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: search fails to deserialize in csharp client after merging #3869
3 participants