Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add searchSingleIndex snippet [skip-bc] #3975

Merged
merged 4 commits into from
Oct 17, 2024
Merged

chore: add searchSingleIndex snippet [skip-bc] #3975

merged 4 commits into from
Oct 17, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Oct 15, 2024 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: CR-7021 & DI-3027

Changes included:

  • add simple but explicit searchSingleIndex snippet

@Fluf22 Fluf22 requested a review from a team as a code owner October 15, 2024 15:25
@Fluf22 Fluf22 self-assigned this Oct 15, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 15, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by da611704db5f853d8ae5c61ca06daef9f01fb413
🍃 Generated commit 0fde60bd64e32cb4b471f8a9e3b3617fc34244d4
🌲 Generated branch generated/feat/add-search-snippet
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1659
javascript 1640
php 1492
csharp 1387
java 1080
python 1015
ruby 871
swift 759

millotp
millotp reviewed Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also keep the simple snippet ?

millotp
millotp previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw only the first one is displayed in the doc, I don't know if it's possible to have multiple

kai687
kai687 previously approved these changes Oct 17, 2024
View reviewed changes
@Fluf22 Fluf22 dismissed stale reviews from millotp and kai687 via e4abacc October 17, 2024 09:50
@Fluf22 Fluf22 requested a review from millotp October 17, 2024 09:52
@Fluf22 Fluf22 changed the title chore: add searchSingleIndex snippet chore: add searchSingleIndex snippet [skip-bc] Oct 17, 2024
shortcuts
shortcuts approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui

@Fluf22 Fluf22 enabled auto-merge (squash) October 17, 2024 12:08
@Fluf22 Fluf22 merged commit 4d23232 into main Oct 17, 2024
28 checks passed
@Fluf22 Fluf22 deleted the feat/add-search-snippet branch October 17, 2024 12:32
algolia-bot added a commit that referenced this pull request Oct 17, 2024
@algolia-bot @Fluf22
chore: add searchSingleIndex snippet [skip-bc] (#3975) (generated) [s…
e3ec895 
…kip-ci]

Co-authored-by: Thomas Raffray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@kai687 kai687 kai687 left review comments

@millotp millotp Awaiting requested review from millotp

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fluf22 @algolia-bot @kai687 @millotp @shortcuts