feat(helper): persistHierarchicalRootCount: true #6478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
commented
Dec 18, 2024
packages/algoliasearch-helper/test/spec/hierarchical-facets/sort-by.js
Outdated
Show resolved
Hide resolved
packages/algoliasearch-helper/test/spec/hierarchical-facets/sort-by.js
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5721ac8:
|
Haroenv
force-pushed
the
feat/change-persist-hier-root-count
branch
from
59db4c2 to
6876b38
Compare
BREAKING CHANGE: the default behaviour of the helper is now persistHierarchicalRootCount: true
It behaves as persistHierarchicalRootCount: true
Haroenv
force-pushed
the
feat/change-persist-hier-root-count
branch
from
6876b38 to
5721ac8
Compare
Haroenv
commented
Dec 18, 2024
| @@ -75,6 +78,19 @@ test('hierarchical facets: using sortBy', function (done) { | |||
| 'categories.lvl0': { beers: 5 }, | |||
| }, | |||
| }, | |||
| // other levels | |||
There was a problem hiding this comment.
this test was wrong and missing the intermediary facet response
|
by the way this means that #6445 (comment) is now fixed for hierarchical in all cases, not just when the flag is set (because the default has changed) |
dhayab
approved these changes
Dec 19, 2024
Haroenv
added a commit
that referenced
this pull request
Dec 26, 2024
* feat(helper): persistHierarchicalRootCount: true BREAKING CHANGE: the default behaviour of the helper is now persistHierarchicalRootCount: true * fix(options): remove persistHierarchicalRootCount option It behaves as persistHierarchicalRootCount: true
Haroenv
added a commit
that referenced
this pull request
Jan 9, 2025
* feat(helper): persistHierarchicalRootCount: true BREAKING CHANGE: the default behaviour of the helper is now persistHierarchicalRootCount: true * fix(options): remove persistHierarchicalRootCount option It behaves as persistHierarchicalRootCount: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the option persistHierarchicalRootCount no longer exists. The default behaviour is now the same as used to be with persistHierarchicalRootCount: true
FX-3185