fix(build): prevent destructure with reuse of same symbol.

[Haroenv]

This is the cause of the UMD e2e failure in next.

Basically the flow is:

1. source code that destructures something in arguments:

function fn({ one, two }) {}

2. esm output of source code

function fn(_ref) {
  let {
    one,
    two,
  } = _ref

3. umd production output (using uglify)

function fn(e) {
  var { one: e, two: t } = e

note the reused variable name

4. output after import through parcel of the prod umd import

function fn(e) {
  var e = e.one,
    t = e.two;

This fixes it by changing step 3 by using terser to:

function fn(e) {
  let { one: t, two: n } = e;
}

note that it doesn't reuse the e variable and thus no longer bugs and has this output in parcel:

function fn(e) {
  var t = e.one,
    n = e.two;
}

This issue started showing up once we changed the browser output of the js umd build to keep destructuring, which had this "rename-bug". Updating to terser is the right solution for the future as it's actually kept updated unlike uglify.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2f9f119:

Sandbox	Source
example-instantsearch-getting-started	Configuration
example-react-instantsearch-getting-started	Configuration
example-react-instantsearch-next-app-dir-example	Configuration
example-react-instantsearch-next-routing-example	Configuration
example-vue-instantsearch-getting-started	Configuration

[dhayab]

🤘