refactor(instantsearch): replace "helper" with the value of "mainHelper" #6516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 631f1c6:
|
dhayab
approved these changes
Jan 9, 2025
packages/vue-instantsearch/src/util/__tests__/createServerRootMixin.test.js
Outdated
Show resolved
Hide resolved
packages/vue-instantsearch/src/components/__tests__/InstantSearch.js
Outdated
Show resolved
Hide resolved
Haroenv
force-pushed
the
refactor/helper-mainHelper
branch
from
b5737af to
631f1c6
Compare
Haroenv
added a commit
that referenced
this pull request
Jan 9, 2025
…er" (#6516) * refactor(instantsearch): remove "helper" in favor of "mainHelper" [FX-3212] * refactor(instantsearch): rename "mainHelper" to "helper" [FX-3212] BREAKING CHANGE: the value search.helper is what used to be search.mainHelper. search.mainHelper no longer exists. Use either search.helper now or search.mainIndex.getHelper()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-3212
BREAKING CHANGE: the value search.helper is what used to be search.mainHelper. search.mainHelper no longer exists. Use either search.helper now or search.mainIndex.getHelper()