feat: support for React 19 #6520
Merged
+686
−661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymeric-giraudet
requested review from
a team,
sarahdayan and
shaejaz
and removed request for
a team
Haroenv
approved these changes
Jan 9, 2025
Haroenv
reviewed
Jan 9, 2025
packages/react-instantsearch-core/src/hooks/__tests__/useInstantSearch.test.tsx
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 86a33c7:
|
Haroenv
previously approved these changes
Jan 10, 2025
|
@Haroenv I tested it on a Vite app with React 19 and it does solve this problem : #6426 (comment) Now instead it uses (also tested with React 18 and it still works as the namespace was already in the |
1 task
Haroenv
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FX-3202
Result
Mostly type-related issues and had to remove
@testing-library/react-hooksin favor of just@testing-library/reactfixes part of #6496