Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement child function #317

Closed

Conversation

DavidBabel
Copy link

@DavidBabel DavidBabel commented Oct 24, 2018

Render a function which render React element is now possible
Fix for #295

Render a function which render React element is now possible
@ghost
Copy link

ghost commented Oct 24, 2018

There were the following issues with this Pull Request

  • Commit: 44fa05e
    • ✖ body must have leading blank line
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@DavidBabel
Copy link
Author

I don't understand what your bot wants.

@SachsKaylee
Copy link
Collaborator

SachsKaylee commented Oct 31, 2018

Hey @DavidBabel

I was rather confused by the commit bot aswell. The commit Bot enforces the commits & PRs to have a certain style.

Commits must have a type and a scope.

If a commit is a feature that adds a formatting for child functions the PR title could be feat(formatting): Render child functions

Commits must be in a similar style. See this link for details https://www.npmjs.com/package/@commitlint/config-angular

You can rewrite your old commit messages and PR title and the bot will pick up on that.

Please also note that the unit tests currently fail.

@ryansukale
Copy link

@DavidBabel Any update on this one? We have run into the same issue with render functions.

@DavidBabel
Copy link
Author

Since it wasn't answered i forked the library with this modifications, but it's very for personnal use, i will not provide any support : https://www.npmjs.com/package/@davidbabel/react-element-to-jsx-string

@SachsKaylee
Copy link
Collaborator

SachsKaylee commented Dec 11, 2018

I'll go ahead and close this Pull Request. Feel free to Re-Open it if you want to have your changes merged into this repository.

Please see my previous comment for the reason why I cannot merge this as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants