-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter Processor Benchmarking #146
Conversation
1fc05d3
to
0e01345
Compare
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 67.66% 71.71% +4.05%
==========================================
Files 32 37 +5
Lines 1976 2747 +771
==========================================
+ Hits 1337 1970 +633
- Misses 570 678 +108
- Partials 69 99 +30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
how do you tell from the output that there's fixed 8ms overhead for each filter? |
But numeric filters seems to be faster. |
1 filter / 1 txn takes about 8ms I think it follows that the number of txn seems to be nicely optimized, but there seems to be some per-filter overhead somewhere. |
Good point, I was definitely looking at the first few results more than the other filter types. |
Summary
Add new benchmarks Benchmarks for filters.
The results suggest that we're doing something extremely inefficient when setting up each additional filter.
Applying one filter to 1 or 25000 transactions has an almost negligible difference.
On the other hand there seems to be a fixed 8ms overhead for each filter.
The numbers in each report are as follows: