Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus: v39 protocol support via go-algorand-sdk #159

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Dec 15, 2023

Summary

Bump go-algorand-sdk dependency to v2.4.0 to support v39 consensus protocol.

Test Plan

Existing tests should pass.

@gmalouf gmalouf added the enhancement New feature or request label Dec 15, 2023
@gmalouf gmalouf self-assigned this Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 199 lines in your changes are missing coverage. Please review.

Comparison is base (442791a) 67.66% compared to head (8ea006e) 72.89%.
Report is 65 commits behind head on master.

❗ Current head 8ea006e differs from pull request most recent head 8d2ac43. Consider uploading reports for the commit 8d2ac43 to get more accurate results

Files Patch % Lines
conduit/pipeline/pipeline.go 84.07% 48 Missing and 20 partials ⚠️
pkg/cli/cli.go 69.64% 29 Missing and 5 partials ⚠️
conduit/plugins/importers/algod/algod_importer.go 88.98% 21 Missing and 4 partials ⚠️
...lugins/exporters/postgresql/postgresql_exporter.go 57.44% 19 Missing and 1 partial ⚠️
conduit/data/config.go 76.47% 11 Missing and 5 partials ⚠️
...duit/plugins/exporters/filewriter/file_exporter.go 52.94% 5 Missing and 3 partials ⚠️
conduit/plugins/exporters/filewriter/util.go 87.93% 7 Missing ⚠️
conduit/telemetry/telemetry.go 86.27% 5 Missing and 2 partials ⚠️
conduit/plugins/importers/filereader/filereader.go 77.77% 4 Missing and 2 partials ⚠️
conduit/plugins/importers/noop/noop_importer.go 80.76% 4 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   67.66%   72.89%   +5.23%     
==========================================
  Files          32       38       +6     
  Lines        1976     2789     +813     
==========================================
+ Hits         1337     2033     +696     
- Misses        570      646      +76     
- Partials       69      110      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalouf gmalouf marked this pull request as draft December 15, 2023 19:46
@gmalouf gmalouf marked this pull request as ready for review December 15, 2023 21:47
@gmalouf gmalouf merged commit fec5307 into algorand:master Dec 15, 2023
3 checks passed
@gmalouf gmalouf deleted the protocol-update-sync branch December 15, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants