CR: fix identityOpts reuse concern

algorand · Jun 21, 2024 · 3c14a74 · 3c14a74
1 parent 5e327fa
commit 3c14a74
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/network/hybridNetwork.go b/network/hybridNetwork.go
@@ -42,14 +42,16 @@ func NewHybridP2PNetwork(log logging.Logger, cfg config.Local, datadir string, p
 	// supply alternate NetAddress for P2P network
 	p2pcfg := cfg
 	p2pcfg.NetAddress = cfg.P2PListenAddress
-	identityOpts := identityOpts{
-		tracker: NewIdentityTracker(),
-	}
-	p2pnet, err := NewP2PNetwork(log, p2pcfg, datadir, phonebookAddresses, genesisID, networkID, nodeInfo, &identityOpts)
+	identityTracker := NewIdentityTracker()
+	p2pnet, err := NewP2PNetwork(log, p2pcfg, datadir, phonebookAddresses, genesisID, networkID, nodeInfo, &identityOpts{tracker: identityTracker})
 	if err != nil {
 		return nil, err
 	}
-	identityOpts.scheme = NewIdentityChallengeScheme(NetIdentityDedupNames(cfg.PublicAddress, p2pnet.PeerID().String()), NetIdentitySigner(p2pnet.PeerIDSigner()))
+
+	identityOpts := identityOpts{
+		tracker: identityTracker,
+		scheme:  NewIdentityChallengeScheme(NetIdentityDedupNames(cfg.PublicAddress, p2pnet.PeerID().String()), NetIdentitySigner(p2pnet.PeerIDSigner())),
+	}
 	wsnet, err := NewWebsocketNetwork(log, cfg, phonebookAddresses, genesisID, networkID, nodeInfo, &identityOpts)
 	if err != nil {
 		return nil, err