-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: Add delete/create to algons dnsaddr command #5631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
requested review from
winder,
iansuvak,
algorandskiy and
shiqizng
August 3, 2023 15:43
algorandskiy
reviewed
Aug 3, 2023
Could you also add |
algorandskiy
previously approved these changes
Aug 8, 2023
winder
previously approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just left a few questions and nits for you to consider.
Eric-Warehime
dismissed stale reviews from winder and algorandskiy
via
August 11, 2023 16:19
70cf8ff
winder
approved these changes
Aug 16, 2023
algorandskiy
approved these changes
Aug 16, 2023
This was referenced Aug 17, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds creation and deletion of dnsaddr trees. Provided a set of multiaddrs and a top level domain,
algons
can now be used as shown below to create a tree of records in DNS which resolves to the full set of supplied multiaddrs.Addresses #5624
Test Plan
Just local CLI testing for now until we start including this in ping-pong tests for the p2p network.