ledger: restore block listeners on reloadLedger #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* algorand#6039 discovered blockNotifier preserves state between ledger reloads that breaks assumptions on how trackers work * Made node to clear and re-register block listeners explicitly on fast catchup. * Also removed unused blockListeners argument from data.Ledger
gmalouf
previously approved these changes
Jun 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6041 +/- ##
==========================================
+ Coverage 55.87% 55.89% +0.02%
==========================================
Files 482 482
Lines 68593 68592 -1
==========================================
+ Hits 38324 38340 +16
+ Misses 27658 27646 -12
+ Partials 2611 2606 -5 ☔ View full report in Codecov by Sentry. |
cce
reviewed
Jun 26, 2024
cce
reviewed
Jun 26, 2024
gmalouf
previously approved these changes
Jun 26, 2024
algorandskiy
force-pushed
the
pavel/ledger-reload-fix
branch
from
318baa2
to
8d4d0db
Compare
algorandskiy
changed the title
algorandskiy
force-pushed
the
pavel/ledger-reload-fix
branch
from
8d4d0db
to
c5723fa
Compare
gmalouf
previously approved these changes
Jun 26, 2024
cce
reviewed
Jun 26, 2024
cce
approved these changes
Jun 26, 2024
jasonpaulos
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
reloadLedgerTest Plan
Existing tests including
TestNodeTxHandlerRestartandTestNodeTxSyncRestartpassed locally.