Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update nightly builds to use universal mac update #6071

Merged
merged 12 commits into from
Jul 25, 2024

Conversation

onetechnical
Copy link
Contributor

Summary

In #6023 we added a universal mac build target. We should switch to this as it's a simplified model for handling Mac binaries. This PR takes the first step by migrating our nightly builds to use this by default.

Note that I did not want to just make Mac universal builds the default for make build. It does, however, presume if you run make universal that you want that as your primary binary.

Also removed arm32 from the updater script, as that platform support has been deprecated.

Test Plan

Been running steps individually, but will also need to see if nightly build/promotion works.

@onetechnical onetechnical self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.11%. Comparing base (48a539f) to head (ebb1b5c).
Report is 5 commits behind head on master.

Files Patch % Lines
util/s3/s3Helper.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6071      +/-   ##
==========================================
- Coverage   56.13%   56.11%   -0.02%     
==========================================
  Files         488      488              
  Lines       69439    69445       +6     
==========================================
- Hits        38978    38968      -10     
- Misses      27813    27823      +10     
- Partials     2648     2654       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one remark about naked return stmt.

util/s3/s3Helper.go Outdated Show resolved Hide resolved
@onetechnical onetechnical merged commit f6fa590 into algorand:master Jul 25, 2024
18 checks passed
@onetechnical onetechnical deleted the universal-mac-updater branch July 25, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants