CI: fix rpmbuild call for cross-platform execution #6134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rel/beta #6134 +/- ##
============================================
- Coverage 56.52% 56.26% -0.26%
============================================
Files 494 494
Lines 69954 69954
============================================
- Hits 39538 39357 -181
- Misses 27747 27926 +179
- Partials 2669 2671 +2 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Sep 18, 2024
cce
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For ARM64, the agent will not run rpmbuild unless you remove the strip option.
Test Plan
Ran manually and verified it worked.