Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus: For Devnet and Betanet, support custom network upgrade delay #6148

Conversation

gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Oct 8, 2024

Summary

For Devnet and Betanet explicitly, support overriding the ApprovedUpgrades delay in consensus parameters during startup. When merged, this shortens the wait time in pre-release testing processes.

Test Plan

Added new test in consensus.go exercising initializing consensus params across 4 of our supported networks. All existing tests need to pass as well.

…rades delay in consensus parameters during startup.
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.24%. Comparing base (3b3b5ce) to head (b72b81b).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
cmd/algod/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6148      +/-   ##
==========================================
+ Coverage   54.28%   56.24%   +1.95%     
==========================================
  Files         494      494              
  Lines       69936    69944       +8     
==========================================
+ Hits        37968    39343    +1375     
+ Misses      29246    27934    -1312     
+ Partials     2722     2667      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/consensus.go Outdated Show resolved Hide resolved
config/consensus_test.go Outdated Show resolved Hide resolved
@gmalouf gmalouf requested a review from cce October 10, 2024 16:55
@onetechnical onetechnical merged commit c9000bf into algorand:master Oct 11, 2024
19 checks passed
@gmalouf gmalouf deleted the short-consensus-upgrade-delay-test-networks branch October 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants