Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: add config flag for ARL to count all messages #6168

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

cce
Copy link
Contributor

@cce cce commented Nov 12, 2024

Summary

Following on #6167 this provides a configuration option (default disabled) to feed messages dropped by ERL (EnableTxBacklogRateLimiting) into ARL (EnableTxBacklogAppRateLimiting), so that all TX messages are counted by ARL, not just the ones that made it past the first pass of ERL's rate limiter.

Test Plan

Merging into a testing feature branch — existing tests should pass.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.27%. Comparing base (cc8dbb7) to head (86e51f0).
Report is 1 commits behind head on experimental-tweaks.

Files with missing lines Patch % Lines
data/txHandler.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           experimental-tweaks    #6168      +/-   ##
=======================================================
+ Coverage                55.91%   56.27%   +0.36%     
=======================================================
  Files                      494      494              
  Lines                    69960    69964       +4     
=======================================================
+ Hits                     39115    39372     +257     
+ Misses                   28160    27912     -248     
+ Partials                  2685     2680       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalouf gmalouf merged commit c837e49 into algorand:experimental-tweaks Nov 12, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants