Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: pre-1.0 doc updates #322

Closed
wants to merge 16 commits into from
Closed

docs: pre-1.0 doc updates #322

wants to merge 16 commits into from

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Jan 8, 2024

Closes #164

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for tealscript ready!

Name Link
🔨 Latest commit 9e5e6b2
🔍 Latest deploy log https://app.netlify.com/sites/tealscript/deploys/65cabc1d4ca110000892691f
😎 Deploy Preview https://deploy-preview-322--tealscript.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joe-p joe-p changed the title docs: Pre-1.0 doc updates docs: pre-1.0 doc updates Jan 8, 2024
@joe-p joe-p marked this pull request as draft January 8, 2024 16:06
@joe-p joe-p force-pushed the docs/pre_1.0_docs branch 3 times, most recently from d46339c to d963e91 Compare January 14, 2024 00:17
@joe-p joe-p force-pushed the docs/pre_1.0_docs branch 2 times, most recently from 977e10b to 875d9c9 Compare January 28, 2024 13:52

## Argument Types

If you are writing a method that must be accompanied by an atomic trasnaction, you can set the argument type to one of the following types: `PayTxn`, `AssetTransferTxn`, `AppCallTxn`, `KeyRegTxn`, `AssetConfigTxn`, or `AssetFreezeTxn`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you are writing a method that must be accompanied by an atomic trasnaction, you can set the argument type to one of the following types: `PayTxn`, `AssetTransferTxn`, `AppCallTxn`, `KeyRegTxn`, `AssetConfigTxn`, or `AssetFreezeTxn`
If you are writing a method that must be accompanied by an atomic transaction, you can set the argument type to one of the following types: `PayTxn`, `AssetTransferTxn`, `AppCallTxn`, `KeyRegTxn`, `AssetConfigTxn`, or `AssetFreezeTxn`


## Verifying An Atomic Transaction

Simply having an atomic trasnsaction as an argument doesn't gurantee anything about the transaction itself. As such, it's important to verify the fields of the transaction to ensure it is doing what you want. There are multiple methods for verifying the different types of transactions: `verifyPayTxn`, `verifyAssetConfigTxn`, `verifyAssetTransferTxn`, `verifyAppCallTxn`, and `verifyKeyRegTxn`. If you the transaction could be multiple different types, use the `verifyTxn` method.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Simply having an atomic trasnsaction as an argument doesn't gurantee anything about the transaction itself. As such, it's important to verify the fields of the transaction to ensure it is doing what you want. There are multiple methods for verifying the different types of transactions: `verifyPayTxn`, `verifyAssetConfigTxn`, `verifyAssetTransferTxn`, `verifyAppCallTxn`, and `verifyKeyRegTxn`. If you the transaction could be multiple different types, use the `verifyTxn` method.
Simply having an atomic transaction as an argument doesn't guarantee anything about the transaction itself. As such, it's important to verify the fields of the transaction to ensure it is doing what you want. There are multiple methods for verifying the different types of transactions: `verifyPayTxn`, `verifyAssetConfigTxn`, `verifyAssetTransferTxn`, `verifyAppCallTxn`, and `verifyKeyRegTxn`. If the transaction could be multiple different types, use the `verifyTxn` method.

@joe-p
Copy link
Contributor Author

joe-p commented Feb 22, 2024

Closing because #439

@joe-p joe-p closed this Feb 22, 2024
@joe-p joe-p deleted the docs/pre_1.0_docs branch May 5, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improved documentation
2 participants