-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PyTypes inheritance handling #346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achidlow
force-pushed
the
fix-pytypes-inheritance
branch
4 times, most recently
from
November 7, 2024 03:39
1950bd0
to
d94efc1
Compare
daniel-makerx
approved these changes
Nov 7, 2024
achidlow
force-pushed
the
fix-pytypes-inheritance
branch
from
November 7, 2024 06:25
d94efc1
to
18012d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more general fix for the issue surfaced in #272.
Equality comparisons between types (including implied equality comparisons in match statements) don't take into account inheritance relationships. Instead a partial ordering operator is needed whenever a type to be compared against isn't guaranteed to be "final".
Two other small changes:
typing.NamedTuple