Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haskell: added DFT and re-wrote FFT #397

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

jiegillet
Copy link
Member

Added previously missing DFT and re-wrote FFT, I was quite unhappy with it, it's better now.

Yay #hacktoberfest #394!

@jiegillet jiegillet added Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Sep 29, 2018
@leios
Copy link
Member

leios commented Sep 29, 2018

So... I don't know if these count as hactoberfest because it's not yet october... But I appreciate them anyway!

@jiegillet
Copy link
Member Author

Oh no!!! It’s not October yet?!
Feel free to reject them then :’(

@leios
Copy link
Member

leios commented Sep 29, 2018

I mean... You could close and re-submit? That's your call.

@jiegillet
Copy link
Member Author

Maybe I’m a hipster and I was coding for hacktoberfest before it was cool?

@leios
Copy link
Member

leios commented Oct 3, 2018

I am having some trouble reading this one. It's because of my limited haskell experience, though. I'll sift through it soon (Unless someone with more haskell exp. wants to take over).

@jiegillet
Copy link
Member Author

I'm happy to walk you through it if you want

@leios
Copy link
Member

leios commented Oct 4, 2018

I might need that. I am getting better at haskell, but I am still a bit behind.

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@leios leios merged commit 95a2811 into algorithm-archivists:master Oct 30, 2018
@jiegillet jiegillet deleted the haskell-fft branch August 31, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants