-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General implementation cleanup #849
General implementation cleanup #849
Conversation
This removes the need for user input
Executing a single java file without compilation (in java >= 11) only works if the first class it finds contains the main method.
[lang: java] [lang: cpp] |
lol whoops though #847 was merged already |
[lang: java] [lang: cpp] |
[lang: cpp] |
[lang: c++] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me.
I'd merge right now, but I'd like to get a second opinion.
This looks good, but did the line numbers for the Monte Carlo and Tree Traversal chapters change? If so, the in-text code-blocks should be updated. It looks like it was done for Verlet and it doesn't seem to be necessary for Huffman. I was just double-checking before merging. |
The fixes for Tree Traversal and Monte Carlo did not require inserting code at the start of the file. However this is different for the other two implementations, which is why the numbers needed to be adjusted there but not for Tree Traversal / Monte Carlo. [When the full code exmaple should be shown (like it is the case at the end of chapters), no line numbers are required in the md file and nothing needs to change there as well] |
Right, great! Thanks again. Happy to merge! |
This PR combines some easy syntactic fixes to standardize implementations for automatic testing and validation (in reference to #824 and #691).
These changes were done (see commit messages for more details):
I tried to keep the formatting close to the original implementations.