-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c# tree traversal: fixed index out of range issue #894
c# tree traversal: fixed index out of range issue #894
Conversation
Yeah, we kinda changed things since tree traversal was added and are really inconsistent with the "submitted by" notes. I think either removing the note or adding a "modified by..." would both be ok solutions to the note |
I removed the submitted line to make it more consistent with the examples in other languages. |
@lazyprop That basically is resolving the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a straightforward change and am happy to merge it. The line numbers seem fine.
I'll wait a second to see if anyone who knows more C# has anything to say before merging. If anyone else wants to click the button, feel free!
Looks good to me as well (I don't know C Sharp that well, but it's readable enough) |
This PR fixes an issue in the
DFSRecursiveInorderBinary
method wherewould throw an
IndexOutOfRange
exception iftree._children.Count == 1
.This PR also removes a couple of redundant
this.
in the constructors.Note: The first line in
Tree.cs
says "// submitted by Julian Schacher (jspp)" and I am not sure if I should make any changes to this line or add something like "modified by ..." because this is not the exact code submitted by Julian?