Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise code directory names #920

Merged

Conversation

ShadowMitia
Copy link
Contributor

@ShadowMitia ShadowMitia commented Nov 6, 2021

This PR standardises all directories that might have different names for the same language. Eg. c++ -> cpp. This should help with #906.

For go/golang like names I decided to use only the name (dropping the lang part).

@ShadowMitia ShadowMitia changed the title Standardise code dirs Standardise code directory names Nov 6, 2021
Copy link
Contributor

@henrikac henrikac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you forgot to update the reference to these code examples in <algorithm>.md e.g. tree_traversal/tree_traversal.md

@ShadowMitia
Copy link
Contributor Author

Oooups 😅

@ShadowMitia
Copy link
Contributor Author

For reference I renamed folders with this command find . -name golang -type d | rename 's/golang/go/' from the root of AAA.

@ShadowMitia
Copy link
Contributor Author

ShadowMitia commented Nov 7, 2021

For reference, this command helps rename paths in files grep -RiIl 'c++' | xargs sed -i 's/c++/cpp/g'. You have to double check because it might rename things that are not paths (eg. example command in C++ which has a -std=c++17 flag).

@henrikac
Copy link
Contributor

henrikac commented Nov 7, 2021

The changes in the "Files changed" tap looks fine to me.

You have to double check because it might rename things that are not paths (eg. example command in C++ which has a -std=c++17 flag).

This is, imo, something that you should have checked before pushing ;)

@ShadowMitia
Copy link
Contributor Author

Nah, I would never do that. I just forgot to change the paths in all the files that needed it. That's perfectly fine 😁

What I REALLY shouldn't do is work on contributions late at night.

Copy link
Member

@ntindle ntindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntindle
Copy link
Member

ntindle commented Nov 7, 2021

Lots of files changed here. Would appreciate two reviews for this one

@ShadowMitia
Copy link
Contributor Author

Also let me know if there are other folders that need renaming.

@ntindle
Copy link
Member

ntindle commented Nov 7, 2021

I would prefer to do them in a separate PR if so due to size and risk mitigation

@ShadowMitia
Copy link
Contributor Author

Fair enough

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also double-checked and I think its good. Thanks again for all the effort here!

@leios leios merged commit 7fe5bfe into algorithm-archivists:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants