-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise code directory names #920
Standardise code directory names #920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you forgot to update the reference to these code examples in <algorithm>.md
e.g. tree_traversal/tree_traversal.md
Oooups 😅 |
For reference I renamed folders with this command |
For reference, this command helps rename paths in files |
The changes in the "Files changed" tap looks fine to me.
This is, imo, something that you should have checked before pushing ;) |
Nah, I would never do that. I just forgot to change the paths in all the files that needed it. That's perfectly fine 😁 What I REALLY shouldn't do is work on contributions late at night. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Lots of files changed here. Would appreciate two reviews for this one |
Also let me know if there are other folders that need renaming. |
I would prefer to do them in a separate PR if so due to size and risk mitigation |
Fair enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also double-checked and I think its good. Thanks again for all the effort here!
This PR standardises all directories that might have different names for the same language. Eg. c++ -> cpp. This should help with #906.
For
go/golang
like names I decided to use only the name (dropping the lang part).