-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analytical): fix the louvain algorithm that the result is not consistent with #183 #3472
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3472 +/- ##
===========================================
+ Coverage 40.90% 70.96% +30.06%
===========================================
Files 109 110 +1
Lines 11343 11384 +41
===========================================
+ Hits 4640 8079 +3439
+ Misses 6703 3305 -3398
... and 63 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
unit test #3474 expect 103 community but 10733
|
Yes, there are still something wrong and it's not related to min_progress parameter, trying to figure out |
I find the real problem for that, it seems that we need to do a |
Very cool. @acezen Can you provide the logic for subsequent processing? I can verify it based on test data. I have been watching GAE for the past two days based on the PIE model, trying to find the root cause in a difficult way. |
later I will push a commit that output the correct result of Lovain, then it should not need user to do the union find. |
hi, @shirly121, the |
9b75cea
to
ba825d7
Compare
What do these changes do?
This change try to fix the louvain algorithm that the result is not consistent with #183
Related issue number
Close #3457