-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(interactive): Add error handling for adhoc queries #4188
Conversation
@@ -20,13 +20,6 @@ namespace gs { | |||
static unsigned long long lastTotalUser, lastTotalUserLow, lastTotalSys, | |||
lastTotalIdle; | |||
|
|||
FlexException::FlexException(std::string&& error_msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That code is no longer used.
Please check the preview of the documentation changes at |
@yecol @sighingnow @siyuan0322 Is there any better way to introduce |
If the development container and builder dockerfile is shared with analytical engine, then boost::leaf is already installed. So maybe you could find boost::leaf in system path first in CMake? If its for users to install manually, then installing boost::leaf could be a prerequisite. |
I got it. But one thing is unclear to me - even though |
Please comfirm with Dongze: .graphscope_env should address the paths issues. |
We could do a link in the dockerfile. |
@zhanglei1949 @dashanji Vineyard does rely on |
Yeah, vineyard will find the boost leaf package first. If not exist, then use the thirdparty code. I think interactive could do the same. |
Great! So correct me if I'm wrong:
|
…ueries Committed-by: xiaolei.zl from Dev container Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container Committed-by: xiaolei.zl from Dev container
24657d2
to
d536349
Compare
Committed-by: xiaolei.zl from Dev container
We Introduce boost::leaf for lightweight error handling in the Interactive Ad Hoc Query Service.
For each operator, we refactor it returns a
bl::result
value, allowing the error to be caught and returned at the most outside, i.e.adhoc_app.cc
.In this PR, we only wrap the errors about
UNSUPPORTED
UNIMPLEMENTED
andBAD_REQUET
at operator level. For lower level errors, we still let it crash.TBD:
Fix #4189
We will continue to resolve these
UNSUPPORTED
andUNIMPLEMENTED
errors, by covering all combination of all params and operators in physical plan.TODO #4190