Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix mtl model label in ut #68

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[bugfix] fix mtl model label in ut #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tzrec/models/dbmtl_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_dbmtl(self, graph_type) -> None:
),
tower_pb2.BayesTaskTower(
tower_name="cost_price",
label_name="label2",
label_name="label3",
mlp=module_pb2.MLP(hidden_units=[12, 6]),
losses=[loss_pb2.LossConfig(l2_loss=loss_pb2.L2Loss())],
relation_tower_names=["is_buy"],
Expand Down Expand Up @@ -277,7 +277,7 @@ def test_dbmtl_has_sequences(self, graph_type) -> None:
),
tower_pb2.BayesTaskTower(
tower_name="cost_price",
label_name="label2",
label_name="label3",
mlp=module_pb2.MLP(hidden_units=[12, 6]),
losses=[loss_pb2.LossConfig(l2_loss=loss_pb2.L2Loss())],
relation_tower_names=["is_buy"],
Expand Down
4 changes: 2 additions & 2 deletions tzrec/models/ple_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def test_ple(self, graph_type) -> None:
),
tower_pb2.TaskTower(
tower_name="cost_price",
label_name="label2",
label_name="label3",
mlp=module_pb2.MLP(hidden_units=[12, 6]),
losses=[loss_pb2.LossConfig(l2_loss=loss_pb2.L2Loss())],
),
Expand Down Expand Up @@ -308,7 +308,7 @@ def test_ple_has_sequences(self, graph_type) -> None:
),
tower_pb2.TaskTower(
tower_name="cost_price",
label_name="label2",
label_name="label3",
mlp=module_pb2.MLP(hidden_units=[12, 6]),
losses=[loss_pb2.LossConfig(l2_loss=loss_pb2.L2Loss())],
),
Expand Down
3 changes: 2 additions & 1 deletion tzrec/modules/embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,8 @@ def __init__(
# TODO (hongsheng.jhs) make dense feature support embedding_dim
if is_wide:
raise ValueError(
"dense feature should not be configured in wide group."
f"dense feature [{name}] should not be configured in "
"wide group."
)
else:
if input_tile and feature.is_user_feat:
Expand Down