Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix find_package() & add option to disable asan #366

Merged
merged 5 commits into from
Jan 30, 2024
Merged

fix find_package() & add option to disable asan #366

merged 5 commits into from
Jan 30, 2024

Conversation

poor-circle
Copy link
Contributor

@poor-circle poor-circle commented Jan 30, 2024 •
edited
Loading

Why

What is changing

  1. the target should add compile options -fcoroutines, so that user don't need to add it manually.
  2. add option to disable asan.

Example

ChuanqiXu9
ChuanqiXu9 reviewed Jan 30, 2024
View reviewed changes
async_simple/CMakeLists.txt Outdated Show resolved Hide resolved
async_simple/CMakeLists.txt Outdated Show resolved Hide resolved
@poor-circle
Copy link
Contributor Author

poor-circle commented Jan 30, 2024 •
edited
Loading

We need release a new version 1.3 after this pr merged, then i will add async_simple to vcpkg.

ChuanqiXu9
ChuanqiXu9 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@ChuanqiXu9 ChuanqiXu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ChuanqiXu9 ChuanqiXu9 merged commit ccb7603 into alibaba:main Jan 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuanqiXu9 ChuanqiXu9 ChuanqiXu9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poor-circle @ChuanqiXu9