Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2106 #2108

Open
wants to merge 2 commits into
base: dev/exp
Choose a base branch
from
Open

Fix 2106 #2108

wants to merge 2 commits into from

Conversation

joechan-cq
Copy link
Collaborator

#2106 中所说,主要原因是MaterialApp中异步处理locale,导致FlutterBoostApp的中Overlay被延后挂载,因此出现initState中的初始化逻辑,无法获取到appState

因此是否可以考虑,在Overlay外再包一层StatefulWidget,在这个StatefulWidget的initState方法中进行原先的初始化逻辑,就能保证Overlay被挂载。

将原先在initState中进行的初始化,改放到确保Overlay被mounted之后的时序中
@joechan-cq joechan-cq requested a review from 0xZOne August 6, 2024 07:25
@0xZOne
Copy link
Collaborator

0xZOne commented Aug 7, 2024

@imcjj 抽时间看看这个PR~

@0xZOne 0xZOne requested a review from imcjj August 7, 2024 01:58
@imcjj imcjj mentioned this pull request Aug 8, 2024
@imcjj
Copy link
Collaborator

imcjj commented Aug 8, 2024

@joechan-cq 解法可行,但是内部讨论后认为可能会影响到对boost内部关键逻辑的理解,所以暂不考虑合入~,具体解释见issue评论区 #2106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants