feat: add ext_default_encoder with prometheus encoder #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyuuttaaoo
requested changes
Aug 20, 2024
pkg/protocol/encoder/protocol.go
Outdated
There was a problem hiding this comment.
这个文件位置和endocoder不太对称，可以统一吗
plugins/extension/encoder/encoder.go
Outdated
There was a problem hiding this comment.
和default_decoder.go统一一下？
plugins/extension/encoder/encoder.go
Outdated
There was a problem hiding this comment.
对应的文档，参考 https://github.com/alibaba/ilogtail/blob/2.0/docs/cn/plugins/extension/ext-default-decoder.md
加入overview docs/cn/plugins/overview.md
顺便把链接加一下（原来整个Extension都漏了）docs/cn/SUMMARY.md
aiops1900
changed the title
aiops1900
changed the title
yyuuttaaoo
approved these changes
Aug 21, 2024
This was
linked to
issues
Sep 10, 2024
henryzhx8
pushed a commit
that referenced
this pull request
Jan 20, 2025
本次代码评审主要涉及将系统中的配置管理从处理过程配置（ProcessConfig）全面迁移至实例配置（InstanceConfig），包括监控指标、配置处理、文件监控、单元测试等多个方面的更新，以支持更细粒度的配置管理。同时，增加了对flusher相关指标的监控，并调整了部分代码结构和逻辑，以适应配置管理的这一变更。 Link: https://code.alibaba-inc.com/sls/ilogtail/codereview/18058664 * Add some plugin metrics and alarms (#1697) * add some metrics * Rename ProcessConfig to InstanceConfig (#1711) * feat: add ext_default_encoder with prometheus encoder (#1704) * feat: add encoder extension interface in pkg/pipeline/extensions * feat: add prometheus encoder whitch implements extension.Encoder interface * feat: add ext_default_encoder extension plugin * refactor: rename package name, var name of encoder * docs: add docs for ext_default_encoder & update docs of other extensions * docs: add ext_default_encoder doc in docs/cn/plugins/overview.md * fix: fix build failed for package referenece * chore: update pkg/go.mod to solve lint failed * fix: fix ci-lint error * Merge remote-tracking branch 'refs/remotes/github_alibaba/main' into merge-main-240822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以flusher_http的配置为例，集成Prometheus Encoder的配置示例