[WIP] support span serializing and data routing #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qianlu.kk <[email protected]>
Signed-off-by: qianlu.kk <[email protected]>
|
当前 PR 包含两个功能：
该分支目前处于联调阶段，整体的实现思路基本不会出现太大的修改了。希望可以先评审一下目前的思路和实现方式，是否需要调整，包括：
后续联调过程中可能还会出现的改动大概包括以下几种：
|
henryzhx8
reviewed
Nov 15, 2024
Comment on lines
400
to
441
| if (telemetryType == "arms") { | ||
| // Parse Match segment | ||
| const char* key = "Match"; | ||
| const Json::Value* itr = config.find(key, key + strlen(key)); | ||
| if (!itr) { | ||
| // Error | ||
| LOG_WARNING(sLogger, ("invalid config!", "telemetry arms need add match tags!")); | ||
| return false; | ||
| } | ||
| // Type | ||
| string type; | ||
| // Key | ||
| std::string tagKey; | ||
| // Value | ||
| std::string tagValue; | ||
| const std::set<std::string> supportDataTypes = { | ||
| "trace", | ||
| "metric", | ||
| "agent_info", | ||
| }; | ||
| if (!itr->isObject() || !GetMandatoryStringParam(*itr, "Type", type, errorMsg) || type != "tag" || | ||
| !GetMandatoryStringParam(*itr, "Key", tagKey, errorMsg) || | ||
| !GetMandatoryStringParam(*itr, "Value", tagValue, errorMsg) || | ||
| tagKey != "data_type" || !supportDataTypes.count(tagValue)) { | ||
| // error | ||
| LOG_WARNING(sLogger, ("invalid config!", "telemetry arms need add match tags!")("type",type)("key", tagKey)("value", tagValue)); | ||
| return false; | ||
| } | ||
| if (tagValue == "trace") { | ||
| mSubpath = "/apm/trace/arms/v1/trace_log"; | ||
| mLogstore = "__arms_default_trace__"; | ||
| LOG_WARNING(sLogger, ("successfully set subpath", mSubpath) ("logstore", mLogstore)); | ||
| } else if (tagValue == "metric") { | ||
| mSubpath = "/apm/metric/arms/v1/metric_log"; | ||
| mLogstore = "__arms_default_metric__"; | ||
| LOG_WARNING(sLogger, ("successfully set subpath", mSubpath) ("logstore", mLogstore)); | ||
| } else if (tagValue == "agent_info") { | ||
| mSubpath = "/apm/meta/arms/v1/meta_log/AgentInfo"; | ||
| mLogstore = "__arms_default_agentinfo__"; | ||
| LOG_WARNING(sLogger, ("successfully set subpath", mSubpath) ("logstore", mLogstore)); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
这边telemetrytype要不干脆写成三种，arms_xxx这样子的，这样就不用这段逻辑了
| @@ -84,14 +83,29 @@ Json::Value SpanEvent::SpanLink::ToJson() const { | |||
| root["traceState"] = mTraceState.to_string(); | |||
| mContext->GetLogstoreName(), | ||
| mContext->GetRegion()); | ||
| } | ||
| if (telemetryType == "metrics") { |
There was a problem hiding this comment.
telemetryType if逻辑的层次是并列的，if else 顺序 log、metirc、span
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.