fix: fix memory management issues when passing config to observer library #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KayzzzZ
approved these changes
Dec 10, 2024
| bool ret = false; | ||
| auto eBPFConfig = std::make_unique<nami::eBPFConfig>(); | ||
| eBPFConfig->plugin_type_ = type; | ||
| eBPFConfig->stats_handler_ = [this](auto stats){ return mMonitorMgr->HandleStatistic(std::move(stats)); }; | ||
| eBPFConfig->stats_handler_ = [this](auto&& stats) { return mMonitorMgr->HandleStatistic(std::move(stats)); }; |
There was a problem hiding this comment.
using NamiStatisticsHandler = std::function<void(std::vector&)>;
|
merged in #1951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor configuration management to ensure memory consistency:
Move both construction and destruction of config to the application side to avoid new/free mismatch errors.
Use pointers instead of static objects to prevent premature destruction after library unloading.