Modify the logic that converts the parsing environment to flags. #2037

quzard · 2025-01-14T04:40:21Z

ilogtail时代gflag不进行变化例如logtail_profile_aliuid，ilogtail_discard_interval
LoongCollector时代gflag均不佳前缀例如loongcollector_conf_dir改为conf_dir
不保留gflag同名小写字母环境变量自动转flag的行为，只把留下重要的gflag本名变成7中的额外转换规则例如check_point_filename在文档中暴露，需要添加为额外转换规则，dirfile_stat_sleep从未暴露过，不再支持小写env。
保留原有特殊env转flag的行为。例如ALIYUN_LOGTAIL_WORKING_HOSTNAME，继续保留。
go插件的env继续保留，若与C++原来就有同名env则必须配套增加LOONG_XXX的名字以统一兼容。Go系统参数不需要增加LOONG开头的名字，如GOGC、GOMEMLIMIT。
自动为gflag生成LOONG_upper(flag_name)环境变量转flag的行为
允许额外增加转换规则，包含3中的额外转换规则和4中比本地配置优先级更高的特殊env(这里逻辑保持不变即可)

core/app_config/AppConfig.cpp

core/prometheus/PrometheusInputRunner.cpp

core/unittest/app_config/AppConfigUnittest.cpp

messixukejia · 2025-01-14T11:01:10Z

core/app_config/AppConfig.cpp

-    PROCESSDIRFLAG(loongcollector_run_dir);
-    PROCESSDIRFLAG(loongcollector_third_party_dir);
+    PROCESSDIRFLAG(conf_dir);
+    if (STRING_FLAG(log_dir).empty()) {


合理性待讨论

plugin_main/plugin_export.go

pkg/flags/flags.go

quzard added 3 commits January 13, 2025 11:06

fix

640698f

LOGTAIL_MODE

22e0956

add sIgnoreFlagSet

f50f3a7

quzard changed the title ~~modi~~ modify ParseEnvToFlags Jan 14, 2025

quzard requested review from messixukejia and yyuuttaaoo January 14, 2025 04:41

quzard added 3 commits January 14, 2025 04:49

add test

76969c0

fix

a80b6b5

add comment

1f0b31b

quzard changed the title ~~modify ParseEnvToFlags~~ Modify the logic that converts the parsing environment to flags. Jan 14, 2025

quzard added 2 commits January 14, 2025 05:46

fix

b5ca144

fix

210192b

yyuuttaaoo requested changes Jan 14, 2025

View reviewed changes

core/app_config/AppConfig.cpp Outdated Show resolved Hide resolved

core/app_config/AppConfig.cpp Outdated Show resolved Hide resolved

core/prometheus/PrometheusInputRunner.cpp Outdated Show resolved Hide resolved

core/unittest/app_config/AppConfigUnittest.cpp Show resolved Hide resolved

quzard added 6 commits January 14, 2025 07:45

fix

2f57a8a

fix

757b5b2

fix test

ba6a6e4

fix

015e0c9

rm

3fcfd7b

LoongcollectorEnvPrefix

2e2f2d2

messixukejia reviewed Jan 14, 2025

View reviewed changes

quzard added 2 commits January 14, 2025 11:32

add test

7cae066

make lint

f4843db

yyuuttaaoo reviewed Jan 15, 2025

View reviewed changes

pkg/flags/flags.go Outdated Show resolved Hide resolved

quzard added 2 commits January 15, 2025 01:47

最后执行，优先级最高

cc5df3e

fix

8d20c8c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify the logic that converts the parsing environment to flags. #2037

Modify the logic that converts the parsing environment to flags. #2037

quzard commented Jan 14, 2025 •

edited

Loading

messixukejia Jan 14, 2025

Modify the logic that converts the parsing environment to flags. #2037

Are you sure you want to change the base?

Modify the logic that converts the parsing environment to flags. #2037

Conversation

quzard commented Jan 14, 2025 • edited Loading

messixukejia Jan 14, 2025

Choose a reason for hiding this comment

quzard commented Jan 14, 2025 •

edited

Loading