Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderer中pageRender调用getDerivedStateFromProps方法触发警告 #2704

Open
owenchen1004 opened this issue Nov 28, 2023 · 6 comments
Open

renderer中pageRender调用getDerivedStateFromProps方法触发警告 #2704

owenchen1004 opened this issue Nov 28, 2023 · 6 comments
Assignees
@1ncounter
Labels
help wanted Extra attention is needed / 老铁，赚 PR 的机会来了

Comments

@owenchen1004
Copy link
Contributor

当对renderer做二次封装时，会出现如下warnning：
image

初步判定PageRenderer调用getDerivedStateFromProps方法时，excuteLifeCycleMethod返回了undefined，而不是一个空值null，导致static方法getDerivedStateFromProps报错。
image
image
@1ncounter
Copy link
Collaborator

@owenchen1004 看起来是这里的问题，欢迎提一个pr来修复它。

@JackLian JackLian added the help wanted Extra attention is needed / 老铁，赚 PR 的机会来了 label Nov 28, 2023
@owenchen1004
Copy link
Contributor Author

@owenchen1004 看起来是这里的问题，欢迎提一个pr来修复它。

稍等 我提了

@github-actions GitHub Actions
Copy link

Hello @owenchen1004. We totally like your proposal/feedback, PR wanted。

你好 @owenchen1004，我们完全同意你的提议/反馈，欢迎 PR。

@owenchen1004
Copy link
Contributor Author

请问pr向哪个分支提？

@1ncounter
Copy link
Collaborator

请问pr向哪个分支提？

develop 分支

@owenchen1004 owenchen1004 mentioned this issue Nov 28, 2023
Merged
@owenchen1004
Copy link
Contributor Author

pr已关联
#2705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1ncounter 1ncounter

Labels
help wanted Extra attention is needed / 老铁，赚 PR 的机会来了
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JackLian @1ncounter @owenchen1004