Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: executeLifeCycleMethod return bug in renderer #2705

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix: executeLifeCycleMethod return bug in renderer #2705

merged 2 commits into from
Nov 28, 2023

Conversation

owenchen1004
Copy link
Contributor

fix：#2704

在getDerivedStateFromProps()加了一个undefined校验，没有直接改executeLifeCycleMethod()，以免影响其他方法。

@owenchen1004 owenchen1004 mentioned this pull request Nov 28, 2023
Open
@JackLian JackLian requested review from 1ncounter and removed request for JackLian November 28, 2023 02:54
@1ncounter
Copy link
Collaborator

@owenchen1004 有一条关于代码风格的建议，建议使用 if 判断，而不是 || 运算符，这样逻辑表述比表达式更加的清晰明了

@owenchen1004
Copy link
Contributor Author

@owenchen1004 有一条关于代码风格的建议，建议使用 if 判断，而不是 || 运算符，这样逻辑表述比表达式更加的清晰明了

感谢指点，换了三元表达式，逻辑上更清晰了

@1ncounter 1ncounter merged commit a8051ae into alibaba:develop Nov 28, 2023
12 checks passed
@JackLian
Copy link
Collaborator

1.2.3-beta.7

@open-digger-bot open-digger-bot bot mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liujuping liujuping Awaiting requested review from liujuping liujuping is a code owner

@1ncounter 1ncounter Awaiting requested review from 1ncounter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owenchen1004 @1ncounter @JackLian